Pascal, is this info posted anywhere else (wiki?). It's exactly the type of info I'd be looking for as a contributing noob.
On Fri, Mar 30, 2012 at 12:43 PM, Pascal Robert <[email protected]> wrote: > Hi Larry, > > Looks good to me! A couple of observations: > > - You need to add a .gitignore file in the project so that the content of > build/ and bin/ is not committed in Git (if you use eGit in Eclipse, right > click on the build folder and select Team -> Ignore). > > - When adding a new project to Wonder, you need to add it to the Ant build > files, in Build/build/build.xml > > You need something like this: > > <target name="ERPDFExamples.all"> > <antcall target="global.application.${build.action}" > > <param name="project.principal.class" > value="er.pdfexamples.Application" /> > <param name="project.name" value="ERPDFExamples" /> > <param name="project.dir" > value="Examples/Misc/ERPDFExamples.all" /> > <param name="wo.system.root.bundles" > value="${frameworks.system.core}" /> > <param name="wo.external.root.bundles" > value="${frameworks.wonder.core}/ERPDFGeneration" /> > </antcall> > </target> > > And in the examples.all target (<target name="examples.all", near the end > of the file), add ERPDFExamples.all > > After you done that, build Wonder (ant examples) and check if your new app > have been built like the other examples > > - If your example is using a database, it should be set to H2 by default, > so that people don't need something else to run it. > > Don't worry if it's not perfect, it will be committed into the integration > branch and built by Jenkins, so if a problem is coming up, I will fix it. > > > > > I have been refactoring some of the pdf generation in a couple apps and > have tried to make it work with ERPDFGeneration. > > I wrote a quick app exercising the new bits and the existing > ERPDFWrapper to avoid breaking anything and I put up an instance of that at > https://www.vasc-alert.com/VA/WebObjects/ERPDFExamples > > > > The example application exercises the basic use of ERPDFWrapper (basic > usage ), the use of FOP to transform html, the use of FOP to transform xml > and combining pdfs generated with different wrappers in ERPDFGeneration. > > > > The code is available on my fork at github. ( > https://github.com/elemgee/wonder) I put ERPDFExamples in Examples/Misc > on my fork. > > I confess that I have not moved all of my stuff to git yet, so I still > have subversion-hassle-implementation-trauma affecting my thinking. > > > > I'm going to go over Pascal's podcast on contributions and organization > before submitting a pull request, but since I've already opened myself up > for ridicule on the git issue, I'd like to get some feedback on code. I've > tried to conform to the organization and design that was already part of > ERPDFGeneration. I am still digging through some of the things that I don't > understand so if I've made mistakes in any part of the design or > implementation, please have at it. > > > > > > Thanks for Q Dolans podcast PDF in 60 seconds ( > http://idisk.mac.com/qdolan-Public/webobjects/PDFIn60Seconds.mov) and all > the contributors to ERPDFGeneration. > > > > > > Larry Mills-Gahl > > [email protected] > > > > > > > > > > _______________________________________________ > > Do not post admin requests to the list. They will be ignored. > > Webobjects-dev mailing list ([email protected]) > > Help/Unsubscribe/Update your Subscription: > > > https://lists.apple.com/mailman/options/webobjects-dev/probert%40macti.ca > > > > This email sent to [email protected] > > > _______________________________________________ > Do not post admin requests to the list. They will be ignored. > Webobjects-dev mailing list ([email protected]) > Help/Unsubscribe/Update your Subscription: > > https://lists.apple.com/mailman/options/webobjects-dev/ted.archibald%40gmail.com > > This email sent to [email protected] >
_______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list ([email protected]) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/archive%40mail-archive.com This email sent to [email protected]
