Two tiny corrections:

On 1 Aug 2016, at 10:32 AM, Paul Hoadley <[email protected]> wrote:

> In any case, the alternative is “last modification wins”, which is the bug 
> Johann was correcting—_validateValueForKey() was previously modifying the 
> original ‘value’ and being allowed to return that, hence trumping any other 
> modifications.

Actually, that’s the bug the second commit fixed, the original bug was that the 
result of _validateValueForKey() was being assigned to ‘value’ and that was 
never referenced again, so partial entity validation was being ignored.

> I just wondered whether it was worth sanity checking the idea here first, 
> because Johann has pointed out that we probably need to modify 
> _validateValueForKey(Object, String) to do the same thing, as currently that 
> method is “last modification wins”:


I forgot to qualify that with a class name: it’s 
ERXPartialGenericRecord._validateValueForKey(Object, String).


-- 
Paul Hoadley
http://logicsquad.net/



 _______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list      ([email protected])
Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/webobjects-dev/archive%40mail-archive.com

This email sent to [email protected]

Reply via email to