I did some work on this in my free time. I checked in a branch with mavenized_wonder yesterday. It fixes the compile problems with ERProfiling and test failures on ERXiss. It allows to import wonder as an existing maven project and build without errors. I replaced log4j with reload4j, and logging still seems to work properly. ERXTest runs with only a few (8) tests broken, but looking at them, I believe it's the tests that are broken, not due to any maven changes. Example applications seem to launch and run okay.
I'll leave it up for a while so you guys have time to check it out. Perhaps we should bump the version to 8.0 on release to signal it is a major build change from previous releases even though code changes were not that much. ________________________________ From: D Tim Cummings via Webobjects-dev <webobjects-dev@lists.apple.com> Sent: Friday, July 29, 2022 10:40 PM To: WebObjects-Dev List <webobjects-dev@lists.apple.com> Subject: Re: [Proposal] Drop Wonder's Ant Build Thanks Hugi That worked. Maven didn't copy the built frameworks into /Library/WebObjects/Local/Library/Frameworks like the ant install used to (sudo ant -Duser.home=$HOME frameworks.install). But my apps are maven now so they don't need that except for when I was eogenerating. I changed default.eogen to point to the built framework in the source code refmodel ../wonder/Frameworks/Core/ERPrototypes/target/ERPrototypes.framework/Resources/erprototypes.eomodeld \ and eogenerate worked. In fact I could have just pointed to the model without building refmodel ../wonder/Frameworks/Core/ERPrototypes/Resources/erprototypes.eomodeld \ Cheers Tim On 29/7/22 22:05, Hugi Thordarson wrote: Hi Tim, currently the easiest way to build Wonder on JDK 17 is to comment out ERProfiling and ERXiss in Frameworks/Misc/pom.xml (given that you don't use those two). Time to revisit this, I guess… https://github.com/wocommunity/wonder/pull/944<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwocommunity%2Fwonder%2Fpull%2F944&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kFNnCi7RTID1wKi1RKcDglxfz1QpNMtzkkUcWPpEy2I%3D&reserved=0> Cheers, - hugi On 29 Jul 2022, at 00:19, D Tim Cummings via Webobjects-dev <webobjects-dev@lists.apple.com<mailto:webobjects-dev@lists.apple.com>> wrote: FYI, these URLs have changed to the following https://gist.github.com/hugithordarson/3c269a3196d0c4f2da486f1109c16d42<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fhugithordarson%2F3c269a3196d0c4f2da486f1109c16d42&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YTamwovZIaXQJBxZjN%2F2sNc1Vm7KcsHNOM7B2S7e1rw%3D&reserved=0> https://gist.github.com/hugithordarson/d2ba6da9e4942f4ece95d7a721159cd1<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fhugithordarson%2Fd2ba6da9e4942f4ece95d7a721159cd1&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fHG3YJzLuig54z57ayWWdHuoNA8GgS6uzcl4Zv0G50s%3D&reserved=0> And by the way, how do I build wonder with maven? I need the frameworks built so I can use eogenerate. I tried cd Frameworks mvn clean install I get [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project ERProfiling: Compilation failure: Compilation failure: [ERROR] /home/tim/git/wonder/Frameworks/Misc/ERProfiling/Sources/er/profiling/classloader/WeavingClassLoader.java:[8,16] cannot find symbol [ERROR] symbol: class Resource [ERROR] location: package sun.misc I am using Java 17 on Ubuntu 22.04 Thanks in advance Tim On 17/6/22 09:26, Hugi Thordarson via Webobjects-dev wrote: Thanks for raising the issue Henrique! It probably comes as no surprise that I support this :). Ted; just to clarify, this proposal only applies to the building of Wonder itself. Wonder's maven build generates artifacts/bundles that can be consumed by Ant applications, so nothing changes in that regard (and if you're using the builds from jenkins.wocommunity.org<https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fjenkins.wocommunity.org%2F&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0swKUaafK3Sa7B%2F7%2FoqLqrOnuOt1TEQQ1XdhEWBBTZE%3D&reserved=0>, you're already using the maven built frameworks). In other words, this won't affect you unless you're building Wonder yourself (and if you are, that's very easy to do with maven). That being said, if you still want to try out maven for your own projects (which I do recommend) the maven wiki docs do indeed need some work. Probably time to finally start working on that… But we mavenistas tend to be helpful if you want to give it a go! And until the docs get some lovin', here are a couple of documents that can help you off the ground: https://gist.github.com/hugith/d2ba6da9e4942f4ece95d7a721159cd1<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fhugith%2Fd2ba6da9e4942f4ece95d7a721159cd1&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LFTGeWzY7tX2%2FPHG9qKQgFeiL%2F5jT3GhV7RXpz1j1cM%3D&reserved=0> https://gist.github.com/hugith/3c269a3196d0c4f2da486f1109c16d42<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fhugith%2F3c269a3196d0c4f2da486f1109c16d42&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kJx%2FMBTlbU3IId5fwRNIj8WrVmkf12a6PI66b%2F87H5M%3D&reserved=0> Cheers, - hugi On 16 Jun 2022, at 22:47, Theodore Petrosky via Webobjects-dev <webobjects-dev@lists.apple.com<mailto:webobjects-dev@lists.apple.com>> wrote: What about us guys whose projects are smallish projects and never instituted Maven... Riddle me this.... how are the docs or examples on the Wiki to implement Maven? Can you point me to some good references so I can come on board? Ted On 6/16/22, 6:42 PM, "Henrique Prange via Webobjects-dev" <webobjects-dev@lists.apple.com<mailto:webobjects-dev@lists.apple.com>> wrote: Hey guys, I've been talking to other Wonder users/committers lately. Keeping the Ant build configuration up to date in Wonder is becoming increasingly counterproductive. Most of us have been using Maven for years. As a result, our environments are not prepared to build the project with Ant, making it hard to check if we broke something after every change. For this reason, I'd like to propose the removal of the Ant build configuration from project Wonder. What do you think? Cheers, HP _______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (Webobjects-dev@lists.apple.com<mailto:Webobjects-dev@lists.apple.com>) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/tpetrosky%40agencysacks.com<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apple.com%2Fmailman%2Foptions%2Fwebobjects-dev%2Ftpetrosky%2540agencysacks.com&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=cWJc8wwnEDG92AUXNtHlt8Xcvw3OSVORSoax3mQOKa4%3D&reserved=0> This email sent to tpetro...@agencysacks.com<mailto:tpetro...@agencysacks.com> _______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (Webobjects-dev@lists.apple.com<mailto:Webobjects-dev@lists.apple.com>) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/hugi%40karlmenn.is<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apple.com%2Fmailman%2Foptions%2Fwebobjects-dev%2Fhugi%2540karlmenn.is&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3AiT2vuTsd9TWRU%2FLBj8Q4vsOZw%2BDl5QhNFBjy4NrJA%3D&reserved=0> This email sent to h...@karlmenn.is<mailto:h...@karlmenn.is> _______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (Webobjects-dev@lists.apple.com<mailto:Webobjects-dev@lists.apple.com>) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/tim%40triptera.com.au<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apple.com%2Fmailman%2Foptions%2Fwebobjects-dev%2Ftim%2540triptera.com.au&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fxogm%2BjYDys9FOBwmp8ZoIPxMaMgFRqcBPbgOucUCzA%3D&reserved=0> This email sent to t...@triptera.com.au<mailto:t...@triptera.com.au> _______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (Webobjects-dev@lists.apple.com<mailto:Webobjects-dev@lists.apple.com>) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/hugi%40karlmenn.is<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apple.com%2Fmailman%2Foptions%2Fwebobjects-dev%2Fhugi%2540karlmenn.is&data=05%7C01%7Cramsey.gurley%40practicemojo.com%7C50b900b621cd433ba2b508da71ee03f9%7Cde0a512999d34d35a92809047a134775%7C1%7C0%7C637947564341499711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3AiT2vuTsd9TWRU%2FLBj8Q4vsOZw%2BDl5QhNFBjy4NrJA%3D&reserved=0> This email sent to h...@karlmenn.is<mailto:h...@karlmenn.is> ________________________________ Confidentiality Notice: This email, including all attachments and replies thereto, are covered by the Electronic Communications Privacy Act, 18 U.S.C. Sections 2510-2521 and are legally privileged. This information is confidential, and intended only for the use of the individuals or entities named above. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this transmitted information is strictly prohibited. Please notify us if you have received this transmission in error. Thank you.
_______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (Webobjects-dev@lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/archive%40mail-archive.com This email sent to arch...@mail-archive.com
