2010/10/21 Elad <[email protected]>: > 2010/10/21 Elad <[email protected]>: >> 2010/10/20 shaiton <[email protected]>: >>> On Wed, Oct 20, 2010 at 5:52 PM, Elad <[email protected]> wrote: >>>> 2010/10/20 Elad <[email protected]>: >>>>> 2010/10/20 shaiton <[email protected]>: >>>>>> On Mon, Oct 18, 2010 at 12:17 PM, אלעד <[email protected]> wrote: >>>>>>> I'm sorry for flooding your mailing list, but i've updated my second >>>>>>> patch again, >>>>>>> now it also moves the globe of the language list to the right side of >>>>>>> the list, fixes the positions of the features page tabs, and fixes a >>>>>>> little problem with the links in the left side of the main page. >>>>>>> >>>>>>> now there are only one problem, Hebrew specific, that i need to fix. :-) >>>>>> >>>>>> I've pushed an update. >>>>>> Please, let me know understand what your "Hebrew specific" fix is doing. >>>>>> >>>>>> +.lang-he #header>.container_16>.grid_3 { >>>>>> +width: 180px; >>>>>> +} >>>>>> Should not be applied for me (it is broking the four foundations >>>>>> columns.) >>>>>> >>>>>> There is two things that should be corrected. >>>>>> The slideshow has a padding-right who need to be removed (under >>>>>> Firefox4, you won't see it under Chrome). >>>>>> The slideshow numbers are still displayed on the left using Chrome >>>>>> (looks good with Firefox4). >>>>>> >>>>>> >>>>>> -- >>>>>> Kévin Raymond >>>>>> GPG-Key: A5BCB3A2 >>>>>> >>>>> the Hebrew specific fix is for a problem that doesn't appear in chrome >>>>> (but does appear in FF): the ok button (אישור) of the language list is >>>>> under, and not beside the list. it caused because of the word אישור is >>>>> longer than the word ok. >>>>> >>>> ignore that, this commit >>>> http://git.fedorahosted.org/git?p=fedora-web.git;a=commit;h=2cf67805f1b1b7dc368a69db7cb64e27069494bf >>>> caused a strange behavior in RTL, so my fix for isn't needed anymore >>>> (i need another fix though). >>>>> also, i think you should add !important to this property >>>>> .webpage-list, .checkmark-list { >>>>> padding-right:15px; >>>>> } >>>>> >>>>> 40px padding is too much for those lists. >>>>> >>>>> screenshots that shows the problems are attached. >>>>> >>>>> thank you for applying my patches. >>>>> >>>>> >>>>> -- >>>>>>Elad >>>>> >>>> >>>> >>>> >>>> -- >>>>>אלעד >>>> >>> >>> fixed >>> >>> >>> -- >>> Kévin Raymond >>> GPG-Key: A5BCB3A2 >>> >> Sorry about the top posting i made in my previous message. >> >> anyway, i've found another problematic rule in rtl_960.css: >> .container_16 .prefix_14 { >> padding-right: 840px; >> } >> should be deleted or otherwise overridden, as it causes the "back to >> top" button to be in a wrong position. >> >> -- >>>אלעד >> > > another problem: while the tutorials and interviews text is > untranslatable, the text is still right aligned. in order to fix this, > you should surround the content in another div, and define that div > as direction: ltr. don't do direction: ltr to the whole page/content, > since the titles and the short descriptions are translated. > > > -- >>אלעד > Since i'm part of the team now, i will make all those fixes myself. thanks.
-- -Elad. -- websites mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/websites
