Prashant Srinivasan wrote: > > Can I get a review for the below webrev please? The changes have been > in Coolstack for a while, and we're tested with Rubybench and have not > found issues. > > I'm hoping to get this in by b105 (12/08). > > http://cr.opensolaris.org/~psriniva/CR6765285/
Change seems ok to me. The revision comments are quite long though, the convention for SFW is to use "$CR $CRSYNOPSIS" so it should only be "6765285 A better CFLAGS variable and configure option" (although you might want to first make the CR synopsis a bit more precise than the vague word "better") (You'll need to rerun 'wx ea; wx redelget' to reset the comment.) -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
