> rahul wrote: >> Hi, >> Can I please get this reviewed ? (updating mod_fcgid to latest) >> http://cr.opensolaris.org/~vrthra/mod_fcgid-2.3.4/ >> > > I just have a few trivial comments. Hopefully Seema will have time to > review as well, and Jyri will look at the ARC soon after he returns. > > i. METADATA: > > I'd make it "NAME: FastCGI plugin for Apache Web Server Version 2.2"
ok. > ii. SUNWapch22m-fcgid/pkginfo.tmpl.patch: > > Does this line need to have the exact version of mod_fcgid? > > DESC="FastCGI plugin for Apache Web Server Version 2.2 (2.3.4)" It was a later convention (After the original integration of mod_fcgid) to specify the version number in parens. However I did not understand what you meant by exact version. Do you mean to change it as (2.3) - i.e avoid minor version? > (same for pkgdefs/SUNWapch22r-fcgid/pkginfo.tmpl.patch) > > > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss ---~*~--- rahul -- 1. e4 _
