Changes looks good to me. Regards, Basant.
On Thu, Oct 29, 2009 at 02:25:32PM -0700, Sriram Natarajan wrote: > thanks basant. Please find the updated webrev which incorporates your > feedback > > http://cr.opensolaris.org/~sn123202/b127/webrev/ > > > - Sriram > > Basant Kukreja wrote: >> 2 small changes. >> 1. In php_6818228.patch.patch, since off_t is defined as long (when >> _FILE_OFFSET_BITS=32) so we should probably use "long" instead of "int". >> 2. In nanosleep patch php_6893909.patch.patch, we can use LDFLAGS to tell >> configure to include "-lrt" >> LDFLAGS="-lrt" ./configure ... >> >> Regards, >> Basant. >> >> On Thu, Oct 29, 2009 at 11:30:45AM -0700, Sriram Natarajan wrote: >> >>> Hi >>> I would like to integrate the bug fixes for following issues within >>> build 127. can some one kindly look into this webrev report and let >>> me know your thoughts.. >>> >>> 6660998 include snmp support within php >>> 6818228 [nvb110] zlib functions are not working on sparc >>> 6825797 php engine dumps core within gettext php test case >>> 6893884 warning thrown while loading xdebug extension >>> 6893909 nanosleep function is not recognized in php >>> >>> WebRev URL: http://cr.opensolaris.org/~sn123202/b127/webrev/ >>> >>> thanks >>> sriram >>> _______________________________________________ >>> >>> >>> webstack-discuss mailing list >>> webstack-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >>>
