[resend] I've been through everything and it looks ok to me. You seem to have updated the Copyright year in every file, including files (particularly the package files) with no other changes and I'd suggest that you revert them back to the parent version. If nothing else it makes the webrev a lot smaller and a lot less daunting, I found myself clicking through lots of files that had no changes.
Amanda Sriram Natarajan wrote: > Hi > Please find the webrev at > http://cr.opensolaris.org/~sn123202/php528.feb9/webrev . I would very > much appreciate your insights > > This webrev addresses the following bugs: > > 6641450 [nvb79] php cgi tests are failing when using delivered php.ini : > php-cgi binary build issue > 6685623 [nvb86] dtrace integration for php generates core dump for zend > tests > 6768395 lighttpd fails to start due to the wrong php paths > 6780290 php function getmyuid shows incorrect uid > 6781705 integrate php 5.2.8 within opensolaris 2009.04 > 6793666 upgrade idn pecl extension to 0.2.0 > 6793668 uprade xdebug pecl extension to 2.0.4 > > > thanks > sriram > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
