Jyri Virkki wrote:
> Jeff Trawick wrote:
>   
>>         The native Solaris LDAP and OpenLDAP SDKs implement some of the
>>         same symbols.  Any libraries loaded into the same process as 
>>         APR-Util and Apache must use the same LDAP SDK, or the behavior
>>         is undefined.
>>
>>         There are believed to be no other users of the APR-Util LDAP 
>>         interfaces besides Apache, but it is is unknown if there are
>>         other users of APR-Util in general which separately use LDAP.
>>         The LDAP SDK use in APR-Util is segregated to the separate
>>         library apr_ldap.so which is loaded dynamically if APR-Util
>>         LDAP functions are called, so it shouldn't be a problem for
>>         such APR-Util applications which separately use LDAP.
>>     
>
> Since this is the potentially controversial part of the proposal, the
> spec should preemptively answer questions about it.
>
> "unknown" and "shouldn't" are bad words in an ARC case...
>
> I recommend checking a recent nevada build to list everything which
> links with APR and confirming those app(s) don't have any issues with
> the change and documenting that investigation.  For approval, the case
> needs to convincingly show this change won't cause breakage elsewhere
> in nevada/OpenSolaris.
>
>   
>>   4.5. Interfaces:
>>        
>>        This affects both APR-Util and Apache.
>>        
>>        Interfaces removed: 
>>     
>
> To avoid confusion I'd write 
> "Imported Interfaces removed (no longer imported)"
>
>   
>>        NAME                         STABILITY          NOTES
>>        
>>        LDAP                         Evolving           PSARC/1997/276 et seq.
>>        
>>        Interfaces added: 
>>     
>
> And same here "Imported Interfaces added:"
>
>   
>>        NAME                         STABILITY          NOTES
>>        
>>        OpenLDAP                     External/Volatile  PSARC/2008/507
>>     
>
> "External" is an old classification no longer used. In fact, reading
> 2008/507 I see it doesn't declare anything to be "External".  So it is
> "Volatile", above.
>
>
>
>   
>>         4.6.1. Implications for Apache configuration
>>
>>         Refer users to the OpenLDAP-specific details for configuring ldaps 
>>         connections at
>>
>>           http://httpd.apache.org/docs/2.2/mod/mod_ldap.html#settingcerts
>>
>>         A sample LDAP configuration showing ldaps connections to the Sun
>>         Directory Server is recommended.
>>     
>
> Nit, but recommended to whom?
> I guess above is saying next apache integration will include such a
> sample?  If so, state it that way: "A sample LDAP configuration
> showing ldaps connections to the Sun Directory Server will be included."
>
>   
Attached is the new ARC case with these comments addressed, as well as a 
diff from the previous version.

Thanks!


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: apache-ldap-arc-02-to-03.txt
URL: 
<http://mail.opensolaris.org/pipermail/webstack-discuss/attachments/20090221/a0b20d7a/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: apache-ldap-arc-03.txt
URL: 
<http://mail.opensolaris.org/pipermail/webstack-discuss/attachments/20090221/a0b20d7a/attachment-0001.txt>

Reply via email to