rahul wrote: >>> http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/Makefile.sfw.udiff.html >>> nitpicks :) >>> 1) perhaps you can use $(SHELL) to invoke configure? >>> >>> >> this has been like that since php 5.2.4. I would probably make the >> change in the next putback. Probably okay with you. >> > > very much ok :) > > >>> 2) why use /usr/ucb/install and _install function both? >>> >>> >>> >> I use /usr/ucb/install on Makefile.sfw and _install within install-php5 >> (shell script). >> >>> I am totally missing what changed in these :( .. >>> >>> http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_Makefile.global.patch.udiff.html >>> http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_dl.c.patch.udiff.html >>> http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_ini.patch.cdiff.html >>> http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_run-tests.php.patch.udiff.html >>> >> These changes only reflect that the patches have been applied for 5.2.9. >> > > possibly you could either remove the version numbers from the patch > filenames, (do you need them any way? I see you are using -p1 ? ) > it seems odd to mark these as changed when nothing really has. > > - not for immediate, but you can possibly do them in a later > putback. > > well, the reason I had this is to ensure that when I upgrade the version, I remember to check every patch that we carry. carrying the version number forces me in one way or the other . Now, without version information, some time patches apply fine (with some hunk) but having version number ensures that I properly migrate those patches. I agree, I need to remove the -p1 from there.
I can file a separate bug to track this issue - sriram
