On 04/17/09 05:46, Sriram Natarajan wrote:
> looks good to me. minor suggestions ..
Thanks for reviewing the changes.

> should these also not be 444 ?
> ins_file favicon.gif ${HTDOCS} 644
> +    ins_file favicon.ico ${HTDOCS} 644
> 
These are user-editable files and hence set to 644.

> 
> any particular reason to depend on /usr/gnu/bin/tar rather than 
> /usr/bin/tar ?
> 
/usr/bin/tar does not support 'z' option.

Thanks,
Seema.


> Seema Alevoor wrote:
>> Hi,
>>
>> Webrev for including the new welcome page for Apache 2.2 is at 
>> http://cr.opensolaris.org/~seema/6631493/ .
>> Kindly review.
>>
>>
>> Thanks,
>> Seema.
>>
>>
>> _______________________________________________
>>
>>
>> webstack-discuss mailing list
>> webstack-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss

Reply via email to