Hi Sriram, On 09/24/08 06:45, Sriram Natarajan wrote: > Seema > > - You don't want to 'set -o xtrace' within install-* script. This was > recommend to me by SFW RE >
Fine, will remove it. > - I see that you compile apr so that it can know about MySQL and > PostgreSQL libraries. Now, does any .so produced from apr depend on > MySQL/PostgreSQL client libraries ? The reason I am asking is you have > /usr/sfw/lib in the RPATH while compiling apr. Since MySQL 4.x based > client libraries reside in /usr/sfw , you might want to make sure that > there aren't any conflicts. > apr-util's .so files do depend on DB client libraries, but the dependency is on a specific version of a client. For e.g, apr_dbd_mysql.so depends on libmysqlclient_r.so.15 So, it should be fine. I will also check the ordering of paths in RPATH. Will make sure db path is before /usr/sfw/lib. > - You are patching the following file : fix-libtool.sed with CC to point > to /opt/SUNWspro. Instead of depending on hard coded location, should > you not simply configure it to use the CC used by SFW build system ? > > /usr/src/cmd/apr/apr-1.3/Solaris/template/fix-libtool.sed > SFW build system path is not a standard compiler location. It is just a convention followed within SUN for ON builds. /opt/SUNWspro is the default location for Sun Studio compiler. > - If you are using 'CXX' for your linking, you need to ensure that it > does not contain any runtime path. You could do this by including > '-xnorunpath'. You can verify your generated .so files by using dump -Lv > *.so > CXX is not used. But still I think it is better to include "-norunpath" in CXXFLAGS. I will make that change. > - You might want to regenerate this patch for 2.2.9 ? Is there any > thought on taking this patch to the apache httpd community ? I see there > are other couple of patches from 2.2.8 . You might want to forward port > it 2.2.9 to reflect the 2.2.9 integration ? > > +--- httpd-2.2.8/srclib/apr/network_io/unix/sockets.c.orig Sat Nov 11 > 02:07:48 2006 > ++++ httpd-2.2.8/srclib/apr/network_io/unix/sockets.c Fri Feb 8 04:54:31 2008 > extended_file.patch overrides this patch. Hence this patch is no longer needed. I have included the patches that are relevant to 2.2.9. Some are not required as they have already been included in 2.2.9 source. And yes, I will submit couple of patches to the community, too. > - Just like the way you patched php5/Makefile.sfw to appropriately look > for its dependent libraries , should you not patch mod_perl/Makefile.sfw > ? What I mean is, currently our SFW build process would break if > SUNWapch22u package is not installed on the system. This I will address it later. Without really trying out the build within such an environment, it will be difficult for me to fix. And, mod_perl is little tricky. For some variables, it hard codes the values while generating the Makefiles and so the changes may involve multiple files. > - You might want to update apache2/METADATA as well. Will add. Thanks and Regards, Seema. > Seema Alevoor wrote: >> Hi, >> >> Webrev is at http://cr.opensolaris.org/~seema/6544042/ . >> For each of the file, I have added a brief summary of the change. >> The main changes include: >> - Apache version update to 2.2.9 >> - Integration of APR and APR-util >> >> This webrev includes fixes for the following bugs. >> # 6544042 >> # 6714814 >> # 6703220 >> # 6737160 >> # 6684489 >> >> Please review. >> >> Thanks and Regards, >> Seema. >> >> >> <http://monaco.sfbay.sun.com/detail.jsp?cr=6684489> >> >> >> >> _______________________________________________ >> >> >> webstack-discuss mailing list >> webstack-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >> > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
