On 10/15/08 10:40, Jyri Virkki wrote: > Sunanda Menon wrote: > >> Please Code Review minor changes for the bug 6758090 : mysql need to be >> compiled with -x04 and also for CR 6759537 >> <http://monaco.sfbay.sun.com/detail.jsp?cr=6759537> mysql_config --libs >> maps to 32 bit libs for 64-bit binary at >> >> http://cr.opensolaris.org/~sunandam/6758090/ >> > > Seems ok to me as far as the diff goes. > > In the bug 6759537 I'd like to see an Evaluation explaining what > happened and what is the fix and its impact. From the diff it seems > the fix_ldpath function must've been wrong since you're removing it, > but then I wonder why was it added in the first place and does > removing it have any consequence beyond fixing the immediate error? > Answer is probably simple enough but this is the kind of rationale > that is good to record in the CR Evaluation for future reference. > Evaluation has been updated in the Bug report.
> Also while the -xO4 change is simple enough, have you validated the > performance difference? > I'll check on this and update . > (Remember to link the CRs to this code review discussion thread.) > > P.S. those monaco URLs are no good on this list since they are not > visible externally. > -- Sunanda Menon Database Technology Group BLR03, x87098/91-80-66937098 http://blogs.sun.com/smenon -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/webstack-discuss/attachments/20081015/a49864ef/attachment.html>
