Sunanda Menon wrote:
>
> As part of the CR :6634053 Integrate MySQL 64-bit release ,I would like
> the changes to be reviewed at
> http://cr.opensolaris.org/~sunandam/6634053/
> Please let me know your comments .
usr/src/Targetdirs
- These lists are mostly kept in alphabetical order, so adjust accordingly.
usr/src/cmd/mysql-5-0/Makefile.sfw
- In addition to Rahul's comments,
- I see you're adding to some hardcoded paths like
-ENVLINE=MAKE=$(CCSMAKE) \
+ENVLINE=MAKE=/usr/ccs/bin/make \
why? Instead of hardcoding, use all the definitions from Makefile.master
so there's consistency in case something ever changes. Above is one
example, but review the changes for other such hardcoded paths.
- Is this indirection needed?
+all : all32 all64
+all32:build_mysql32
+all64:build_mysql64
- In the two configure calls, there's a lot of repetition of the options,
which means they will most likely get out of sync over time when someone
modified one list but not the other. Instead, use a common section for
all the flags which are common between the two build modes. See php5
Makefile.sfw for one example of such.
usr/src/pkgdefs/SUNWmysql5u/prototype_*
- Here also alphabetical listing is better
That's what I noticed..
--
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
