Gopalakrishnan Sankaran wrote: > > Please review CR 6705310 rbconfig.rb file contains improper paths for > INSTALL and configure_args parameters. This results in make install > failing during the gem install process.
Could you document (just here in the discussion, I don't mean in the code) which gems have been tested after installing the package built with your changes, so we have a sense of which ones are known to work now? > Here is the webrev link. > http://cr.opensolaris.org/~gs193864/cr6705310/ So, here it's hardcoding the "configure_args" line to the given value, but that line also contained (in addition to the incorrect paths you're trying to fix) the configure options used by the build. My concern is what will happen in the future when some of the configure options are changed in the Makefile but, inevitably, don't get changed in these sed lines in postinstall-ruby, resulting in binaries that were built with options inconsistent with what's in rbconfig.rb? > Jyri, > Have added the WebRev: link in the comments section. Cool, thanks! -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
