Jyri Virkki wrote: > Prashant Srinivasan wrote: > >> Can someone review this patch from the upstream community? It updates >> > > Not sure what you mean by "patch from the upstream community"? We're > not reviewing that (nor do we need to), just your build changes. >
You're right, the review request is for my Makefile changes, not the upstream patch. > >> http://cr.opensolaris.org/~psriniva/webrev-6721879-v2/ >> > > Seems ok to me, except remember to delete the old ruby-1.8.6.tar.bz2 now. > > I assume you've verified that nothing has changed interface-wise here, > Yes . . . as far as I can see. I've requested the webstack QA lead for some more verification. > but it'd be good to point to the release notes in this review thread. > > > Here are the release notes for the security patch - http://www.ruby-lang.org/en/news/2008/06/20/arbitrary-code-execution-vulnerabilities The Ruby folk do not generate release notes, hence we don't have a list of fixed bugs handy. -ps -- Prashant Srinivasan F/OSS Enthusiast Sun Microsystems, Inc. http://blogs.sun.com/prashant GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/webstack-discuss/attachments/20080703/8797f3fa/attachment.html>
