Stefan Teleman wrote: > Victor Kirkebo wrote: > >> Please find the webrev at >> http://cr.opensolaris.org/~vk136562/memcached-1.2.5-CR6717705/ >> > > Two questions: > > 1. Have you determined that -xO5 generates the best performing code on both > SPARC and Intel. The fact that -xO5 is the highest optimization level doesn't > always mean it generates the fastest, best performing code. Aggressive > inlining > can sometimes lead to cache thrashing, which ends up having the exact > opposite > effect from the one intended. > No, I don't think we have tested this really. But I'd like to keep it for now and make a decision when we'd had time to test this. > 2. ./configure --prefix=/usr > > Wouldn't it be better to say: > > PREFIX=/usr > > ./configure --prefix=$(PREFIX) \ > [ ... ] > --localstatedir=/var \ > [ ... ] > > By default, ./configure sets ${localstatedir} to ${prefix}/var. This will > translate to /usr/var. If memcached needs to create temporary files in > ${localstatedir}/tmp, it won't work (/usr/var/tmp can't exist in Solaris). > > What ./configure really means by ${localstatedir} is /var (and use /var/tmp > for > temporary, run-time files). My suggestion would be to change the call to > ./configure and explicitly indicate the location of ${localstatedir} as /var. > Done. I used CONFIGURE_OPTIONS as suggested by another reviewer.
Victor > --Stefan > > --- > Stefan Teleman > Sun Microsystems, Inc. > Stefan.Teleman at Sun.COM > > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >
