Sunanda Menon wrote: > > Hi > > Please review the code at http://cr.opensolaris.org/~sunandam/6640449/ > and let me know your comments .
The RBAC additions look ok to me, make sure to do testing on your system though. Don't make the data directories world readable, that'll give everyone access to the data therein, not a good idea in general. Postgres also has 700 mode dirs under /var/postgres/8.2/ surely for the same reason. If you need to wait until the mysql user is added (CR 6636848) to fix 6640449 without making the data world-readable, then do so (also please update the notes in the bug (6640449) documenting this dependency.) I notice some of the file diffs don't show a change in the version (ident line). Something wrong in your workspace with those, check & correct that. Also, every file has the default putback comment of "NO_COMMENT", be sure to run "wx ea; wx redelget" to create and set the comments. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
