Sunanda Menon wrote: > > Hi , > > Please review the mysql user creation as part of Solaris and let me > know your comments . > > http://cr.opensolaris.org/~sunandam/6636848/
Looks ok to me; a few notes: - In the change log entries it has "6636848: Create ...", the convention is actually "6636848 Create ..." (i.e. space instead of colon between "$BUGNUM $BUGSYNOPSIS") - usr/src/pkgdefs/common_files/i.group Lots of whitespace lines addeed in the diff, probably not needed? As an aside, please also log a separate bug to track the related changes to be done later on sfw side (update man page, set mysqld user/group ownership to appropriate files) once this has gone into ON. Thanks.. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
