Chris Zhu wrote:
>
>
> I updated [1]http://cr.opensolaris.org/~chriszhu/CR6635487-webrev/
> for all 3 bugs CR6641045,CR 6635487 and CR6632021.
usr/src/pkgdefs/SUNWruby18u/prototype_com:
- Update copyright date to 2008
- Diff doesn't show the ident version changing, something is off.
- Instead of just adding a separate block of new entries at the
end, integrate them into the list. Alphabetical sorting is
the usual convention.
usr/src/cmd/ruby18/postinstall-ruby:
- Copyright info
- Diff doesn't show the ident version changing, something is off.
- Nit: in the comments it says in 2 places "copy installed" but
looking at the code later it looks like it is "soft linked", no?
The comments should match the implementation.
usr/src/cmd/ruby18/Makefile.sfw:
- Copyright info
- Diff doesn't show the ident version changing, something is off.
As to the other questions, are you planning on simultaneously
continuing to ship/make available multiple versions, as opposed to
just providing an upgrade path?
If yes, please look into solutions between now and before the ruby19
packages become available. It might involve defining generic actions
for IPS (work with pkg-discuss community) or encouraging building some
common tool to handle this or some other solution.
--
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
