Hello Jyri , The code changes have been done with _install P option .Please review again at http://cr.opensolaris.org/~sunandam/6640026 and let me know your comments .
Thanks Sunanda Sunanda Menon wrote: > Hi Jyri , > > Thanks for informing .Let me work using _install P option . > > Thanks Sunanda > > Jyri Virkki wrote: >> Sunanda Menon wrote: >> >>> Hi , >>> >>> As part of CR: 6640026 I would like my code to be reviewed at >>> http://cr.opensolaris.org/~sunandam/6640026. >>> The perl path changes have been fixed in install-mysql script . >>> >>> Please let me know your comments . >>> >> >> The _install function used in the install scripts has a 'P' type >> (see usr/src/tools/install.subr) that should clean up the >> perl invocation. Is it possible to leverage this global function >> instead of writing a local copy to do something >> equivalent? >> >> Note that if the default changes (someday in the future), your code >> will become incorrect as it hardcodes "/usr/perl5/bin/perl". If you >> can leverage "_install P", it'll pick up such global changes >> automatically. >> >> >> > > -- Sunanda Menon Database Technology Group BLR03, x87098/91-80-66937098
