Seema Alevoor wrote: > > Recently, segv was observed in 2.2.8 which was caused by one of the > apr-util changes which went in 2.2.8. > A patch has already been committed to apr-util trunk as r630780. > I made the changes to include this patch in our apache2 build. > > Updated WebRevs are at http://cr.opensolaris.org/~seema/6653066/ . > Please review.
Looks ok, but I keep thinking the tracking of the patches can be made a bit easier. I see the comments saying apr_brigade.patch corresponds to "r630780", but how will you (or someone else who doesn't remember this thread) in the future easily know whether the fix is in the sources next time the opensolaris version gets upgraded (well you'll know when the patch fails but I was hoping for something cleaner)? Looking at apache release notes http://www.apache.org/dist/httpd/CHANGES_2.2.8 it seems the issues fixed are listed by bugid so why not mention the apache bugid that corresponds to each *.patch in the Makefile.sfw (when available)? (This can also help highlight which *.patch files are opensolaris-specific and don't [yet?] correspond to upstream apache bugids.) -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
