Sriram Natarajan wrote:
> Jeff - You have some valid points. If you notice the some of the
> comments history in this bug - 6670736 - this point was indeed discussed.
Does this show the comments history?
http://bugs.opensolaris.org/view_bug.do?bug_id=6670736 (I don't see the
comments, or any links :( )
> But, some one pointed out why we could have '-mt' set within our
> project Makefile to avoid any misinterpretation. Also, please note
> that in our environment, we are compiling APR with threaded support.
> So that , we can reuse the APR both for pre-fork and worker version of
> httpd.
You mean that -mt when you build worker you get the build of APR which
is also used with prefork, and thus prefork picks up the -mt too?
(prefork needs multithread settings too, whether that is -mt or the old
defines).
> However, it is very possible that there might be other customers who
> don't want to build APR with threading support - for various reasons.
I wouldn't suggest automatically adding -mt in APR without checking for
--disable-threads. But note that APR currently hard-codes multithreaded
settings on Solaris (_REENTRANT, _POSIX_something) without checking for
--disable-threads.
It sounds to me like the APR hard-coding of flags for threads on Solaris
should look like:
if !disable-threads
if $CC -flags | grep -- '^-mt.*multi-threaded' >/dev/null 2>&1
use -mt for compiling and linking
else
use -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT for compiling
fi
fi
Thanks!
