On 08/14/08 20:51, Jeff Trawick wrote:
> Seema Alevoor wrote:
>> I have updated the webrev ( http://cr.opensolaris.org/~seema/6670736/ ).
>>
>> Main changes include patches to apr_hints.m4 and apr_common.m4
>> apr_hints.m4 - to add the threaded flags.
> Attached is an updated patch to solve:
> * We can't change default for --enable-threads
Hmm...in the same file, at couple of other places (for different platforms),
the value of enable-threads was changed as below:
APR_SETIFNULL(enable_threads, [no])
I too followed the same.
> * Hide stderr from "$CC -flags" to avoid noise when building with gcc
> * (Existing issue) Don't mess with large-file settings, because:
> ** Adding ?-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64? isn't necessary.
> APR >= 1.something already does ?-D_LARGEFILE64_SOURCE? by default.
Defining -D_FILE_OFFSET_BITS=64 causes a failure when conifure tries to enable
-D_LARGEFILE64_SOURCE !
----
configure: checking whether to enable -D_LARGEFILE64_SOURCE
configure: result: no
----
This is because off_t value differs when _FILE_OFFSET_BITS=64 is defined and
this causes
the following condition to fail during configure.
if (sizeof(off64_t) != 8 || sizeof(off_t) != 4) {
exit(1);
}
> ** This type of compile setting is a potential ABI change. If we did
> this here and APR didn't already do it, we'd be incompatibile with apps
> written for APR and compiled against a normal APR build. (In fact, a
> Sun-distributed httpd broke the ABI of its Apache 2.0/APR 0.9 with such
> a change.)
>
> Any idea why we need both -mt and _POSIX_PTHREAD_SEMANTICS?
>
_POSIX_PTHREAD_SEMANTICS is required for using the POSIX semantics and -mt will
not define this.
If it is not defined, the compilation will fail with the following errors.
"user/unix/groupinfo.c", line 44: prototype mismatch: 5 args passed, 4 expected
"user/unix/groupinfo.c", line 44: warning: improper pointer/integer
combination: op "="
"user/unix/groupinfo.c", line 72: prototype mismatch: 5 args passed, 4 expected
"user/unix/groupinfo.c", line 72: warning: improper pointer/integer
combination: op "="
cc: acomp failed for user/unix/groupinfo.c
Regards,
Seema.
