Isvaran Krishnamurthy wrote: > > Please find attached the draft ARC case text for including phpMyAdmin > 2.11.5.1 into SFW.
Aside from review details, my level zero issue is that it's a bit too preliminary for this case (though having some starting point document doesn't hurt). Now that we have an accessible experimental web stack package repository, let's use it for hosting the evolving package and experimenting with the issues coming up in this review. After the implementation has matured and there is agreement on all details we can then approach ARC. Is the source tree (and thus package) up to date with this proposal so we can try it? > This ARC case delivers phpMyAdmin 2.11.5.1 as a component in SFW stack. What's the interface compatibility story for phpMyAdmin? Will 2.11.5.2 or any 2.11.5.* be compatible? How about all/any 2.11.*? 2.*? 3.0? This is one of the vital data points to research. While some of it is about predicting the future, you can make educated predictions by researching all the past release notes and talking to the phpMyAdmin community about both past compatibility experience as well as future intention from its developers. (The compatibility aspect is probably mainly on the user editable config file.) The answers from the above research need to be documented in the ARC case. > 2.1.2 File to configure apache with a new URL mapping for /phpmyadmin > > /etc/apache2/2.2/conf.d/phpmyadmin.conf Therefore this is intimately tied to apache22 packages (which is ok, but consider and document the implications). What's the story when apache24 packages become available? > 4. Packaging and Delivery > > phpMyAdmin is delivered in SUNWphpmyadmin package. That's probably the wrong choice given how closely it is tied to SUNWapch22 (and maybe even the PHP5 version?) > 5.1 Imported Interfaces > > NAME STABILITY NOTES > > Apache PHP5 module Uncommitted PSARC 2007/552 > PHP5 for MySQL Uncommitted PSARC 2007/656 How closely is phpMyAdmin tied to PHP versions and MySQL driver versions? While not a direct dependency, which versions of MySQL can it manage? > http://hostname:portnumber/phpmyadmin/ Uncommitted URL for > launching phpMyAdmin Can't the admin change that by simply editing the config? Doesn't sound like an interface. Peter Tribble wrote: > > Or, to ask the question directly: if the phpMyAdmin package is > installed, will the url mapping be enabled by default? > > I would expect not. But it seems that it is. > > However, it appears that the supplied apache httpd.conf simply > Includes conf.d/*.conf so that everything installed is enabled by > default. I'm not at all sure that's a good idea, but that's a more > general problem and isn't a specific problem with phpMyAdmin. That is an excellent point, to which the answer is that OpenSolaris is right in the middle of a transition period and the optimal answer is different on either side.. If this package goes into the traditional Nevada-based distribution (one DVD with all packages and they all get installed at once), clearly the phpMyAdmin package cannot automatically enable itself since the reality is that most people don't want it enabled on their apache server. On the other hand, when installing from a package repository (Indiana-style) the best answer is for phpMyAdmin to drop it's config into conf.d when the package is installed. Since this is not a default package on the LiveCD, it will only ever get installed by those users who specifically want to use phpMyAdmin, so having it deliver live configuration is the right answer for them. The latter offers a better user experience so hopefully it can be done. For now I suggest making the package available on the experimental repository where it can be installed by choice. Hopefully after it matures it can "graduate" to a stable repository of add-on packages without going through the Nevada consolidations. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems