On Wed, Oct 24, 2007 at 07:04:29AM +0200, Roland Mainz wrote:
> 3. Nit: Use "/usr/bin/ksh" (or "/usr/bin/ksh93"), not "/bin/ksh":
> -- snip --
> + MAKE=/usr/ccs/bin/make \
> + /bin/ksh ./configure \
> -- snip --
> BTW: What about using /usr/bin/ksh93 in this case ?
Actually, why call any shell explicitly -- does configure not have the #!
magic?
> Quotes missing, e.g. please change this to
> [ ! -f "${CONF_FILE}" ] && exit $SMF_EXIT_ERR_CONFIG
I'd really rather not see an overabundance of quotes where none are
necessary. If there aren't any spaces and all values are non-null, there's
no need. And in such a straightforward script, where that's easily
checked, you really shouldn't need them at all.
> - Who or what defines "_install" (I'm not happy about the leading "_" in
> front of the same... usually it indicates something (bery) "private" and
> I'm not sure whether it applies in this case...) ?
That's install.subr, which is sourced. It's baked, but feel free to rework
it (and all the gate scripts which use it) if you want to spend the time.
> > +install_errtxt() {
> > + cd errors
> > + for i in `ls -p | grep '\/$'|sed 's/\/$//'`
>
> Somehow I wish you would use /usr/bin/ksh93 for this (e.g. neither "ls"
> or "sed" would be neccesary in this case) ... ;-(
Roland, admit it: you wish everyone would use ksh93 for everything. :)
Danek
