Ritu Kamboj wrote:
>
> Hi,
>
> Kindly find the webrev for MySQL integration at :
>
> http://cr.opensolaris.org/~rkamboj/MySQLWebRev/
The comments are all still "NO COMMENT" - see wx ea/wx redelget.
/usr/src/cmd/Makefile
- Adds mysql-5-0 but older mysql still there?
Solaris/mysql.1.sunman
- Should add the boilerplate
"Source for mysql is available on http://opensolaris.org";
in the NOTES section (see other sfw components for examples)
SUNWmysql5r/prototype_com
63 f none var/svc/manifest/application/database/mysql.xml 0444 root sys
should be "manifest" instead of "none" right? And see CR 6625975 for gotchas.
SUNWmysql5r/depends
- Looking at files I noticed dependencies on SUNWlibmsr,SUNWzlib
copyright files:
As it mentions [L]GPL it probably needs the Sun preamble - but check
with cteam on this.
--
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
