Jyri Virkki wrote: > Sriram Natarajan wrote: > >> webrev for PHP bug fixes >> http://cr.opensolaris.org/~sn123202/php-bugfixes/index.html >> > > * Not too important, but in the bug synopsis, I would > "should not be relevant to workspace" =~ s/relevant/relative/ > (the bug synopsis is the one and only revision history preserved by SFW!!) > > +1. > * monaco URL doesn't work off-SWAN, but these are also at e.g. > http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6625381 > > I will update the bug report to refer to these urls. > * Nit again, but keeping the indentation consistent looks nicer. I'm > cut & pasting only one here but most of the added lines in both > SUNWphp524core/depend and SUNWphp524usr/depend diffs don't have the > same indentation as the existing lines > > P SUNWcsu Core Solaris, (Usr) > + P SUNWcurl C-URL Wrappers Library > > thanks. I have addressed it.
- sriram
