rahul wrote:
>
> Updated webrevs for apache2 modules integration (fcgid,jk,security2) into 
> SXDE are below.
> http://cr.opensolaris.org/~vrthra/apache-modules/

I'll echo some of Arvind & Danek's comment, I'll skip the details
since they covered some ideas already..

But in the big picture, while there are only 3 modules here, you are
establishing precedent for future apache modules. If over time there
are, say, a dozen modules here I think this arrangement will get too
cluttered.  To the extent that it makes sense, look to establish some
layout & infrastructure here so that adding more modules will be clean
& easy and can reuse/include as much as reasonable in terms of
build/install rules, so that every new module doesn't have to cut &
paste everything all over.


-- 
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems

Reply via email to