Matt Ingenthron wrote:

> pick two files and diff them.  If the expectation is that I'd have to 
> check out everything, then open some tarballs just to diff two files, 
> that won't be very useful. 
I agree that it will be very useful to have OpenGrok operate on the 
sources. I don't think diff for the component sources would apply as 
those sources (for a particular version) would never change. Even if we 
did explode the source.tar.gz distros and check them in, I didn't think 
we would be modifying those sources and committing those changes in the 
opensolaris repository. that would essentially fork our sources from the 
upstream community. instead, like the Linux distros and Nevada's sfw 
repository, I thought we would only carry patches that will be applied 
to the community's released source.

http://cvs.opensolaris.org/source/xref/sfw/usr/src/cmd/apache2/

> 
> I think it would be good for the upstream communities to be able to see 
> the source as it had started there, and Sun's modifications (if any) 
> easily through a web based tool.
> 

As I understand things, Sun's modifications will be in the .patch files. 
  So upstream communities would look at our patch files to see our changes.

Even if we did checkin every component's sources into the repository, we 
wouldn't be making modifications to those sources and committing those 
changes to our repository. Instead we would generate a patch and apply 
the patch to the community-released version of the sources. I think this 
is what the Nevada sfw folks are doing.

For example,
http://cvs.opensolaris.org/source/xref/sfw/usr/src/cmd/subversion/
contains the .tar.gz, the sources and a few .patch files. If you look at 
the diff for Makefile.in in 
http://cvs.opensolaris.org/source/xref/sfw/usr/src/cmd/subversion/subversion-1.4.3.patch
 
and compare that with the checked-in version of Makefile.in 
(http://cvs.opensolaris.org/source/xref/sfw/usr/src/cmd/subversion/subversion-1.4.3/Makefile.in)
 
you'll see that Sun's changes haven't been committed to the repository.

Arvi


Reply via email to