Changes look fine. -- Seema.
rahul wrote: > Hi, > The updated webrev for 6626831 is below. > http://cr.opensolaris.org/~vrthra/6626831.squid/ > > Changes from the earlier posted: > > 1) Uses (P) to update the perl version > > 2) Depends on SUNWperl584core alone. (updated after looking through the > perl files.) > > could I please get these reviewed? > > > | > | > Hi, > | > | > I have posted the webrev for 6626831 (Adding Perl dependency > to squid > | > | > depends file ) at > | > | > http://cr.opensolaris.org/~vrthra/6626831/ > | > | > > | > | > | > | Why is SUNWperl584usr needed? (The Evaluation comment in the bug report > just > | > | mentions SUNWperl584core). > | > > | > I am not sure how the dependencies are calculated by check-deps.pl > | > (havenot checked) but the SUNWperl584usr seems to contain very common > | > modules like getcwd, hostname, find, getopt/s. Perl being a very dynamic > | > language, it may be impossible to determine all the modules that is > | > necessary just by static analysis alone (like grepping for require.) > | > > | > so I thought it was safer including both. > | > > | > rahul > | > | Actually, SUNWperl584usr package depends on SUNWperl584core. So, adding > just SUNWperl584usr > | to the list should be good enough. But the convention seems to be explicitly > | list the package dependencies. > > rahul > -- > 1. e4 _ > _______________________________________________ > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
