Amanda Waite wrote: > Jeff Trawick wrote: >> sunanda menon wrote: >>> Hi , >>> Please do a Code Review request for the upgrade of MySQL from 5.0.67 >>> to 5.0.77 (CR 6808952) >>> at http://cr.opensolaris.org/~sunandam/6808952/ >>> >> it looks okay to me, though it would be good for somebody more >> familiar with packaging to have a look as well ;) > > I'd do it, but I'm used to doing reviews on sfwnv-discuss and you guys > might think some of the suggestions that I make are excessively > nit-picky. What types of review comments are there (staying away from the term "nit-picky")?
* identification of changed code that introduces a problem (functional, legal, whatever) ** must resolve in the current review package before integrating * identification of changed code that could be improved (maintainability and/or consistency) ** track via separate CR if integration is high priority and there's no time to resolve immediately * identification of existing problem
