Jeff Trawick schrieb: > Sriram Natarajan wrote: >> Hi >> I would appreciate if you can kindly look at the webrev for these bug >> fixes. they are urgent and need to be addressed for build 111. This >> includes fix for CR >> >> http://cr.opensolaris.org/~sn123202/php529.mar16/webrev/ > > The mcrypt change looks simple enough (+1). > > Is David around to look at the DTrace change? BTW, what is the failure > scenario? Do the DTrace settings change during execution such that the > save/restore and reevaluation on entry is required? We try to emulate internaly the beavior that ext/dtrace implements. I also ran the regression suite and didn't find any error. I just saw that a we have a few indention issues, nevermind, that's not important, is it? As I did some of the implement I'm not able to vote on that webrev. Mcrypt looks good for me. Thanks sriram for the hard work
David > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss -- David Soria Parra - Software Engineer Sun Microsystems GmbH Sonnenallee 1 85551 Heimstetten Germany www.sun.de mailto: david.soriaparra at sun.com Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Wolfgang Engels, Dr. Roland Boemer, Thomas Schroeder Vorsitzender des Aufsichtsrates: Martin Haering
