chris zhu wrote: > > Hi all, > > Please help to review the CR6784907 "specify path to ginstall, and add > gnu-coreutils as a dependency in rbconfig.rb". > The webrev is ready on > http://cr.opensolaris.org/~chriszhu/CR6784907-webrev/
Looks ok to me. In the CR, please add in the Description a description of the problem(s) you encountered that led to wanting to make this change. That helps others in the future who might experience it to find the CR by searching the info. > And the following importance gems are tested: rails, mongrel, thin, > eventmachine, RubyInline, image_science(with FreeImage) Thanks, such testing is very useful to know for external gems. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems