On Wed, Jan 21, 2009 at 4:51 PM, rahul <Rahul.G.Nair at sun.com> wrote: > Hi, > The changes for upgrading mod_jk to 1.2.25 is available here > http://cr.opensolaris.org/~vrthra/6787047-mod_jk/ > > Can I please get these reviewed?
Not an official review - I wouldn't consider myself competent for that - but just some comments. Your subject says 1.2.25 The pkginfo.tmpl has been modified. I'm not sure why the description needs to change at all; it shouldn't be to 1.2.25 as that's the wrong version; the description field reads very badly with the jk version number in brackets after the apache version number. METADATA.jk again says 1.2.25 -- -Peter Tribble http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/
