HI Please find the updated webrev at this below location http://cr.opensolaris.org/~sn123202/webrev.2/
> Hi Sriram, > > Some minor comments.... > > 1. usr/src/cmd/php5/METADATA : > SRC field should be updated to point to the > latest source. done > > 2. usr/src/cmd/php5/Makefile.sfw > Does 5.2.8 include php_cgi_main.c.patch changes > ? > yes, it does > 3. usr/src/cmd/php5/patches/idn_config.patch : > Should "SEARCH_FOR" value include the "/" at the > beginning of the path ? > the config.m4 script does that. it works with the current patch :-) > 4. usr/src/cmd/php5/patches/php_configure.patch : > Has one extra blank line at the end of the file > which can be removed. > > ok > rds, > Seema. -- This message posted from opensolaris.org