Sorry, I wanted to provide couple of comments but had accidentally 
pressed send earlier.

here is the follow up

1. in usr/src/cmd/lighttpd14/Solaris/fcgi-php.conf , It is probably 
better if you could just leave it at /usr/php/bin/php-cgi without 
specifying the INI location.  CGI binary will know where to look for its 
INI file. With the current setup, /usr/php/bin/php-cgi is a symbolic 
link to either /usr/php/5.2/bin/php-cgi or /usr/php/5.3/bin/php-cgi 
(once this is integrated).

+var.php_bin-path           = "/usr/php/bin/php-cgi -c /etc/php/5.2/php.ini"


Looks good to me
Thanks
Sriram


Amanda Waite wrote:
> Sriram Natarajan wrote:
>> php cgi binary is at /usr/php/5.2/bin/php-cgi . We do not have it 
>> delivered at /usr/bin/php-cgi (yet)
>
> Sorry, I see where you mean, I was reading '/usr/php/bin/php-cgi'. 
> It's the commented line, I just made a typo there.
>
> Updated webrev at http://cr.opensolaris.org/~tekgrrl/CR6871404/
>
> Thanks
>
> Amanda
>
>>
>> - Sriram
>>
>> Amanda Waite wrote:
>>> Hi all,
>>>
>>> I'm updating Lighttpd in SFW to v1.4.23 and would really appreciate 
>>> it if you could review my code. The Webrev is here:
>>>
>>> http://cr.opensolaris.org/~tekgrrl/CR6871404/
>>>
>>> Things to note are that as the Lighttpd source no longer bundles 
>>> spawn-fcgi we've moved it into a separate package SUNWspawn-fcgi. As 
>>> per the Arc Case (http://arc.opensolaris.org/caselog/LSARC/2009/562) 
>>> we've maintained the old spawn-fcgi paths in the Lighttpd packages.
>>>
>>> Cheers
>>>
>>> Amanda
>>> _______________________________________________
>>>
>>>
>>> webstack-discuss mailing list
>>> webstack-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
>

Reply via email to