rahul wrote: >> Hi >> I would like to address following php bugs within build 128 >> >> 6877619 remove redundant PHP DTrace extension >> 6891913 deliver httpd conf file for PHP integration via FastCGI when >> mod_php can't be used >> 6893914 split 3rd party extensions into its own packages >> >> Web Rev URL: http://cr.opensolaris.org/~sn123202/b128.1/webrev/ >> > > -Makefile.sfw: > Just a suggestion, You might want to join the names of extensions into > a single variable and then append install_ or build_ to them at once so > that the names need not be repeated again. > > If you don't mind, I will skip this for now as it not affects the behavior of current diff. I would like to keep this change to minimal at this point. I will capture it as a separate bug and refine it later (in another putback.) > why do you have renamenew in SUNWphp52r-apc/idn when the files do not use it > (perhaps *.ini should be renamenew?) > > ok > shouldn't the user packages depend on root pkgs? (what is the > convention?) > > makes sense. > Do these components have their own versions ? (If so, perhaps you want > it in parens along with php version in description?) > > makes sense as well
Please find the updated diff at http://cr.opensolaris.org/~sn123202/b128.3/webrev/ thanks for your time . - Sriram > otherwise +1 > > >> Your comments are most appreciated >> >> Thanks >> Sriram >> _______________________________________________ >> >> >> webstack-discuss mailing list >> webstack-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >> > ---~*~--- > rahul > -- > 1. e4 _ >
