Amanda, This mainly looks good to me, but below are a few observations (feel free to ignore) ...
Amanda Waite wrote: > > Can I get a code review for an update to Ruby 1.8.7. This updates Ruby > 1.8.7 to patch level 174 and updates RubyGems to v1.3.5. > > The webrev is here: http://cr.opensolaris.org/~tekgrrl/CR-6871383 > > The patch file ${SRC}/cmd/ruby18/patches/ruby_nogdbm.patch had to be > removed and re-added so as to reset its permissions. 1. usr/src/cmd/ruby18/Makefile.sfw Why is the 'protofix' done under the 'all: rule rather than under the 'install:' rule? Why are ruby and rubygem builds done under the 'install-*' rules rather than under the 'all:' or another rule(s)? (ie. separating them from the 'install') Line 95, maybe the 'env ' should be 'env - ' 2. usr/src/pkgdefs/SUNWruby18u/prototype_com Should you have the write-permission bit set on the files in here? Paul -- Paul Cunningham Unemployed Software Engineer
