Nick This below patch is for APC - which in turn is an extension that sits on top of PHP engine. If this is patch going for PHP engine, then as you suggested backward compatibility break issue will come in play. Here, the patch is already committed in the upstream community and there aren't other consumers who write module / extensions on top of APC. Hence, I think, this patch is okay. Does this address your concern ?
- Sriram Nick Kew wrote: > On 18 Nov 2009, at 21:13, Basant Kukreja wrote: > > >> Hi, >> Kindly review the webrev for CR >> 6901297 : reserved_offset in APC should be true global (not a thread local) >> >> http://cr.opensolaris.org/~basantk/6901297/webrev/ >> >> Changes have been committed in new version of APC (new version is not >> released >> yet). >> http://pecl.php.net/bugs/bug.php?id=15984&edit=2 >> > > Is apc_globals.h a public API in PHP? If so, you're breaking API/ABI > compatibility, which will in turn affect third-party add-ons/modules/etc. > Is that PHP practice? > >
