Thanks for your comments. As per your comments, I have revised the patch and webrev. http://cr.opensolaris.org/~basantk/6903732/webrev/
Regards, Basant. On Tue, Nov 24, 2009 at 11:25:08PM +0100, David Soria Parra wrote: > On 22.11.09 18:14, Basant Kukreja wrote: >> On Sun, Nov 22, 2009 at 03:08:08PM +0100, David Soria Parra wrote: >>> Are you planning to backport the usage of HAVE_ZEND_LONG64 in >>> zend_multiply.h, zend_operators.h ? >> No, I am just using zend_ulong64 for new safe_address function which is >> implemented in php 5.3. There is no risk of backward incompatiblity here >> because safe_address is a static (and inline) method in zend_alloc.c. If you >> think it is better then I can reduce the scope of zend_long64 in >> zend_alloc.c. > I would prefer if we can reduce it. Otherwise it looks fine for me. > > David > > -- > David Soria Parra - Software Engineer > > > Sun Microsystems GmbH > Sonnenallee 1 > 85551 Heimstetten > Germany > www.sun.de > mailto: david.soriaparra at sun.com > > Amtsgericht Muenchen: HRB 161028 > Gesch?ftsf?hrer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel > Vorsitzender des Aufsichtsrates: Martin Haering
