Yeah, a try: except: around handleRequest would catch a lot of this, I
THINK, but it makes me a little nervous to do a catch that big. It just
seems a little cludgy. But I guess as long as the except logs the error
somehow (just print to stdout), its better than nothing.

I haven't looked at any of this, but why was that particular exception
hanging the thread?

Jay

> -----Original Message-----
> From: Geoff Talvola [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, September 04, 2001 5:35 PM
> To: Jeff Johnson; [EMAIL PROTECTED]
> Subject: RE: [Webware-devel] Bad cookies hang Webkit
> 
> 
> At 05:00 PM 9/4/01 -0400, Jeff Johnson wrote:
> >I guess there's a bug in Cookie.py but shouldn't AppServer be more
> >robust?  A bug like this should cause an error page (which 
> it does) but
> >it shouldn't be able to hang the entire WebKit server.  If we put a
> >try/except around handleRequest would that make it harder for bad
> >servlet code to hang the server?
> 
> You're 100% correct -- we should put a try/except somewhere 
> in here to 
> protect against bugs like this.  (Although we are already 
> well-protected 
> against bugs in servlets -- if an exception happens in your 
> servlet code, 
> it gets handled correctly.  It's any bugs in the rest of 
> WebKit that are 
> the problem.)
> 
> Jay, do you have any opinion on where to put such a 
> "catch-all" exception 
> handler?  Perhaps we can just wrap the call to rh.handleRequest() in 
> ThreadedAppServer.threadloop() in a try/except.  That ought 
> to catch just 
> about any possible error and let the thread stay alive.  I'll 
> make the 
> change but since you're the most familiar with this code, I 
> want to get 
> your opinion.
> 
> 
> --
> 
> - Geoff Talvola
>    [EMAIL PROTECTED]
> 
> _______________________________________________
> Webware-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/webware-devel
> 


----------------------------------------------------------------------------

This e-mail and any attachments may be confidential or legally privileged.
If you received this message in error or are not the intended recipient, you
should destroy the e-mail message and any attachments or copies, and you are
prohibited from retaining, distributing, disclosing or using any information
contained herein.  Please inform us of the erroneous delivery by return
e-mail. 

Thank you for your cooperation.

----------------------------------------------------------------------------



_______________________________________________
Webware-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/webware-devel

Reply via email to