> -----Original Message----- > From: Chuck Esterbrook [mailto:[EMAIL PROTECTED]] > Sent: Thursday, February 07, 2002 1:20 AM > To: [EMAIL PROTECTED] > Subject: [Webware-devel] Session.expiring() > > > Session.expiring() is supposed to be called whenever the session > expires. I see it called only in SessionStore: > > def cleanStaleSessions(self, task=None): > [snip] > sess.expiring() > del self[key] > > But there are other places that get rid of of sessions, like > Application.isSessionIdProblematic(). > > I noticed this because my context installs a custom session > class into > the application (for logging purposes). > > Seems to me that __delitem__ of the various SessionStores should be > invoke expiring() so that the ultimate source of removal > doesn't matter. > > A flag will be needed so the message isn't sent twice by > DynamicSessionStore. > > > Anyone have any comments on this proposed change?
Sounds like a good idea. If we're gonna have methods like "expiring" then we should make sure they are called in all circumstances. - Geoff _______________________________________________ Webware-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/webware-devel
