Regarding patch 630505
http://sourceforge.net/tracker/index.php?func=detail&aid=630505&group_id=4866&atid=304866

This catches the case where an error occurs during encoding while saving the session to a file. The patch to SessionFileStore.py safely handles the exception and does not save a corrupted file (Current behavior is to store a session which can't be loaded.)

The patch to SessionDynamicStore however only removes the session from memory if it was successfully saved to disk.

This may be reasonable for debugging, but is it reasonable for a released version? In a released system, won't this open the door for extra large memory consumption? Couldn't it also interfere with the session caching?
It seems that in released version of the product, that the safest failure would be to just discard the session if this occurred. Information about the failure is still printed to stdout to help in tracking things down. It seems like this might also be an argument for a generic logging interface, to send something to a permanent log as well.

Your thoughts?

-Stuart-




-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
Webware-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/webware-devel

Reply via email to