On Sunday, May 10, 2020 at 11:37:17 AM UTC-4, Till Maas wrote: > > > > 4. weewx.conf gets automatically patched by an upgrade. This is a big > > feature of weewx over the standard package upgrades, which merely ask > a > > user if they want to "merge" their old config file with an incoming, > new > > config file. > > What exactly is happening here? >
the weewx configuration file (nominally weewx.conf) is modified during the upgrade. if you use setup.py and install a new release of weewx on top of an existing one, it will modify the existing weewx.conf so it will work with the latest release. it saves the old file, of course. this works on weewx config files all the way back to 1.0 if you use dpkg/apt-get/apt to upgrade weewx, after the install it will run wee_config and do exactly the same thing. but the results use debian nomanclature - "do you want to use your config or use the one suggested by the software author?". it saves whichever you do not choose so you can compare. if you use rpm/yum/dnf it does the same thing, but with redhat nomenclature. a long long time ago, the configuration modification code was embedded in setup.py. it has since been moved to a module, and it can be called independently of setup.py using wee_config. > > 5. The modules 'user' and 'schema' would have to move to avoid name > > collisions, to weewx.user and weewx.schema, respectively. To maintain > > backwards compatibility, dynamic imports would automatically try > their new > > locations. > > There are also six.py, which I guess could be removed and users should > be asked to install it from their distribution or via pip and daemon.py > (which I guess could be moved in the weewx package). > this is tricky. six and daemon are just one file each, and they basically never change. imho, it does not make sense to create a dependency for each of them - just distribute them as part of weewx, and do updates as necessary. > The user directory is the directory where wee_extension adds new > extensions, isn't it? > > On first thought, the best approach for me would be that the recommended > way to install extensions would be that they use pip as well for > installation. Everything that wee_extensions installs, would be best > moved to /var/lib/weewx/user or similar to ensure that it does not > conflict with the packaged files from weewx. Seems like it would be > $HOME/.local/share or $XDG_DATA_HOME if installing per-user. There does > not seem to be a better counter part for /var/lib. > agree that /var/lib is the appropriate place for this kind of thing. right now /var/lib/weewx is where the sqlite databases reside. adding a /var/lib/weewx/user directory would not be unreasonable, but it would require more python path munging. > > 6. Support for our "standard platforms," which generally includes the > > platforms listed in Matthew's compatibility matrix > > <https://github.com/weewx/weewx/wiki/weewx4-compatibility-matrix>. > > > > Did I miss anything? > > The items in ./util are not managed by setup.py, are they? > those are samples, with defaults (typically) set to a /home/weewx configuration. in the case of deb and rpm installs, most of the util contents are copied to /etc/weewx, and paths changed appropriately. that way all you have to do on a deb or rpm system is make a symlink to the appropriate file in /etc/weewx. for example, for logwatch, logrotate, rsyslog, etc. > > Any volunteers? > > I would like to contribute. My challenge is that I am rather new to > weewx, so I do not have the full picture, yet. > that is a benefit - your eyes are not blinded by looking at the thing for too long :) i think we have a pretty healthy review process, although it sometimes takes awhile. (i have been particularly overwhelmed the past year and a half, so i am grateful to those who have covered for me wrt weewx until i get back to it) -- You received this message because you are subscribed to the Google Groups "weewx-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/weewx-development/c00464fd-edac-4421-9680-9cb50d02fa2d%40googlegroups.com.
