Gee, I sat down, getting ready to track down and eliminate all uses of logging in wee_config, just to discover... it doesn't do any. It just uses print statements.
However, what it does do, is a gratuitous 'import weeutil.logger', but then never uses it. Easy fix. setup.py never did any logging. However, it executes wee_config as a subprocess, so that's where the logging calls came from. Don't know what 'wee_util' is. Commit 791de74 <https://github.com/weewx/weewx/commit/791de746449abed8ec054364b96cf25a71abde38> . -tk On Thu, May 21, 2020 at 11:28 AM Vince Skahan <[email protected]> wrote: > On Wednesday, May 20, 2020 at 9:48:13 AM UTC-7, mwall wrote: > >> install should not require syslog (or any other) logging. deb/rpm just >> extracts assets from the .deb/.rpm. setup.py has an explicit import of >> 'log' from 'distutils' - not sure what logging mechanism that uses, but >> probably not syslog. >> >> configure does require logging, but probably should not. configuration >> is done by invoking wee_config, and that imports weeutil.logger. >> >> it should be possible to refactor wee_config and the code it uses so that >> there are no more weeutil.logger dependencies. >> >> > Are we far enough along in the discussion to create a couple/few github > issues and move things there ? > - setup.py requiring logging > - wee_config requiring logging > - I think wee_util also requires it, if I remember one report correctly > > > I got further along dockerizing, albeit with workarounds - current status > in https://github.com/vinceskahan/weewx-docker - still to do: get rpms to > install in docker successfully and run ok with logging. Working on it..... > > -- > You received this message because you are subscribed to the Google Groups > "weewx-development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/weewx-development/ca24fbe5-09f7-4226-9410-b710394fb9f7%40googlegroups.com > <https://groups.google.com/d/msgid/weewx-development/ca24fbe5-09f7-4226-9410-b710394fb9f7%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "weewx-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/weewx-development/CAPq0zECsNEn9uTTXjHcNDa2t_shiOJ-Cx_V0RH_Xpii5%3D9Y9bw%40mail.gmail.com.
