Tom,
I can confirm that the fix works perfectly.
Thanks
Ian

On Wednesday, July 12, 2023 at 1:14:01 AM UTC+1 Steeple Ian wrote:

> Thanks Tom.
>
> On Wednesday, July 12, 2023 at 12:41:43 AM UTC+1 Tom Keffer wrote:
>
>> Fixed in commit 6a4ab52 
>> <https://github.com/weewx/weewx/commit/6a4ab5246bed68e52bc4faa708c1b16126e9a37a>
>> .
>>
>> These almanac properties now have new names, which return a ValueHelper. 
>> To avoid breaking old skins, the old names, which return a simple 
>> number, can continue to be used.
>>
>> If your skin is targeting many different versions of WeeWX, you should 
>> use the old names.
>>
>> I'll upload a new beta version with the changes once I get to a stable 
>> point. In the meantime, you can swap out almanac.py 
>> <https://raw.githubusercontent.com/weewx/weewx/6a4ab5246bed68e52bc4faa708c1b16126e9a37a/bin/weewx/almanac.py>
>>  
>> if you wish.
>>
>>
>>
>> On Tue, Jul 11, 2023 at 3:07 PM Steeple Ian <[email protected]> wrote:
>>
>>> Checking version 5 with my skin which makes extensive use of the 
>>> extended almanac tags: -
>>> I am comparing V5.0.0b8 with V4.10.2
>>>
>>> The version of ephem on both installations is the latest 4.1.4
>>>
>>> I have noticed an issue with the following which I use in a .tmpl file 
>>> to generate jsondata: -
>>>
>>> $almanac.mercury.hlong
>>> $almanac.venus.hlong
>>> $almanac.sun.hlong
>>> $almanac.mars.hlong
>>> $almanac.jupiter.hlong
>>> $almanac.saturn.hlong
>>> $almanac.uranus.hlong
>>> $almanac.neptune.hlong
>>> $almanac.pluto.hlong
>>>
>>> With V4.10.2 they resolve (correctly?) as in this excerpt: -
>>>       "mercury hlongitude": {"value": 157.59676596526106},
>>>         "venus hlongitude": {"value": 268.7607311602382},
>>>         "earth hlongitude": {"value": 289.2181312716669},
>>>         "mars hlongitude": {"value": 174.82131459911764},
>>>         "jupiter hlongitude": {"value": 30.08049119910007},
>>>         "saturn hlongitude": {"value": 332.3489727103565},
>>>         "uranus hlongitude": {"value": 49.6533340016879},
>>>         "neptune hlongitude": {"value": 355.8446048891469},
>>>         "pluto hlongitude": {"value": 299.07169001740743}, 
>>>
>>> However with V5.0.0b8 this happens:-
>>>        "mercury hlongitude": {"value": 157:58:24.5},
>>>         "venus hlongitude": {"value": 268:53:14.0},
>>>         "earth hlongitude": {"value": 289:17:39.5},
>>>         "mars hlongitude": {"value": 174:51:23.6},
>>>         "jupiter hlongitude": {"value": 30:05:16.0},
>>>         "saturn hlongitude": {"value": 332:21:05.4},
>>>         "uranus hlongitude": {"value": 49:39:15.2},
>>>         "neptune hlongitude": {"value": 355:50:42.2},
>>>         "pluto hlongitude": {"value": 299:04:19.5}, 
>>>
>>> I am assuming that this is an error or is there a change which requires 
>>> additional formatting?
>>>
>>> Ian       
>>>
>>>
>>>
>>>
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "weewx-development" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to [email protected].
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/weewx-development/b3b8f67b-02a6-47d7-beac-a50cc325a908n%40googlegroups.com
>>>  
>>> <https://groups.google.com/d/msgid/weewx-development/b3b8f67b-02a6-47d7-beac-a50cc325a908n%40googlegroups.com?utm_medium=email&utm_source=footer>
>>> .
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"weewx-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/weewx-development/0d64932c-cbaa-42c9-ab66-b15578e6f654n%40googlegroups.com.

Reply via email to