Pushed https://github.com/poblabs/weewx-belchertown/pull/250
Brice Ruth, FCD Software Engineer, Madison WI On Mon, Feb 17, 2020 at 2:13 PM Brice Ruth <[email protected]> wrote: > Roger that. > > Brice Ruth, FCD > Software Engineer, Madison WI > > > On Mon, Feb 17, 2020 at 2:05 PM Pat <[email protected]> wrote: > >> PR's are welcome on the Belchertown skin! Please pull against the >> development branch and I'll check it out >> >> On Monday, February 17, 2020 at 2:54:18 PM UTC-5, Brice Ruth wrote: >>> >>> Good afternoon - >>> >>> I've noticed that, on the iPhone, when I launch my PWS site from the >>> homescreen, using the previously created icon (thank you!) - the websocket >>> doesn't "reconnect" if you switch away and go back after a while. Doing >>> some research, it seems that at some point, Apple modified homescreen >>> launched apps to "save state" - which ... doesn't re-execute any JS >>> automatically, seemingly. I did find a pattern to work around this here >>> https://stackoverflow.com/a/56944455 and I've locally applied this on >>> the version I'm running (I don't think I'm on the beta?). I basically did a >>> minor refactor of the code that's tied to click/restart-interval, and used >>> that to tie to the visibilitychanged event that seems to get triggered. >>> >>> Limited testing seems to indicate that this works. Any concerns with me >>> pushing up a PR for this? Anything else I should be aware of? >>> >>> Thanks! >>> >>> Brice Ruth, FCD >>> Software Engineer, Madison WI >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "weewx-user" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/weewx-user/54c9bfde-cefc-4073-b741-003726ca9d5f%40googlegroups.com >> <https://groups.google.com/d/msgid/weewx-user/54c9bfde-cefc-4073-b741-003726ca9d5f%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "weewx-user" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/weewx-user/CAFbExW4gdeO4hofzZnoQnPT_8e7HO_tzsp9bBeDCjT5-ZT0QPA%40mail.gmail.com.
