See PR https://github.com/matthewwall/weewx-as3935/pull/2 please.

matthew wall schrieb am Freitag, 17. November 2023 um 00:21:07 UTC+1:

> On Thursday, November 16, 2023 at 2:42:43 PM UTC-5 kk44...@gmail.com 
> wrote:
>
> There is an extension <https://github.com/matthewwall/weewx-as3935> 
> available created by Matthew Wall and reading the AS3935 lightning detector 
> circuit. It sets 2 observation types:
>
>    - avg_distance
>    - lightning_strikes
>
> In contrary to that, the wview_extended schema as well as units.py in 
> WeeWX define other observation types for the same purpose:
>
>    - lightning_distance
>    - lightning_strike_count
>
> Why they are different?
>
>
> because i am stupid.  i wrote the AS3935 code rather quickly, so i could 
> compare that sensor with some other lightning detection equipment we were 
> experimenting with.  only later did we create the wview_extended schema, 
> and the intent there was to extend the schema with labels and structure 
> that were general enough to accommodate a wide range of hardware.
>
> i should probably modify the AS3935 code to use the wview extended schema 
> names...
>  
>
> I found no assignment of a unit group to the observation types used by 
> Matthew Wall's extension. Is that intended?
>
>
> it is lazy coding on my part, not intentional.
>  
>

-- 
You received this message because you are subscribed to the Google Groups 
"weewx-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to weewx-user+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/weewx-user/44ce5d2a-1b4f-4d21-a048-7d4db0260cc2n%40googlegroups.com.

Reply via email to