On 30 Sep 2011, at 14:32, Stuart Douglas wrote: > > On 30/09/2011, at 10:43 PM, Pete Muir wrote: > >> >> On 30 Sep 2011, at 13:25, Stuart Douglas wrote: >> >>> Hi Guys, >>> >>> I have just gone through and converted to arquillian the last of the jboss >>> test harness tests in the weld distribution. Unfortunately it is not >>> possible to move all the tests across, as some tests have a dependency on >>> the embedded weld container, which is not available in the incontainer >>> profile (as the AS7 container is used instead). >>> >>> With this is mind, I would like to make some changes to the test suite >>> setup: >>> >>> - rename tests-arquillian -> testsuite/integration >> >> Sounds good. >> >>> - rename tests -> testsuire/unit >> >> I would suggest rewriting the tests as proper integration tests. A lot of >> this stuff is junk left over from when we were bootstrapping the WebBeans RI >> project and didn't have any test harness at all to run with. > > I am not sure if this is possible, as some of them rely on starting and > shutting down the container > (org.jboss.weld.tests.unit.cluster.NaiveClusterTest). I know this test has > actually picked up problems in the past, so I don't really want to ditch it.
Good point. Can we not move this to weld/core then? > >> >>> - Get an alpha release of the 1.1 TCK and setup weld so it can be run >>> against both 1.1 and 1.0 >> >> Sounds good. >> >>> >>> Aslo, is there any reason why we can't merge the porting package into the >>> TCK runner? >> >> We can't do that. GlassFish use the porting package but don't use our test >> runner. > > There are 4 classes in it, cant they just copy them to their own code base? Siva, wdyt? _______________________________________________ weld-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/weld-dev
